Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement fee whitelist #203

Merged
merged 4 commits into from
Oct 2, 2023
Merged

feat: Implement fee whitelist #203

merged 4 commits into from
Oct 2, 2023

Conversation

mpetrun5
Copy link
Collaborator

Implement a fee whitelist for admin set addresses to enable some protocols or users to avoid fees.

Description

Related Issue Or Context

Closes: #202

How Has This Been Tested? Testing details.

  • unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@mpetrun5 mpetrun5 changed the title feat: fee whitelist feat: Implement fee whitelist Sep 27, 2023
@lastperson
Copy link
Contributor

Event for the whitelist changes would be useful.

@mpetrun5
Copy link
Collaborator Author

Event for the whitelist changes would be useful.

Added

@MakMuftic
Copy link
Contributor

@viatrix as we were talking, we would then leverage this for hashi adapters/

@mpetrun5 mpetrun5 merged commit 4463bcb into master Oct 2, 2023
5 checks passed
@mpetrun5 mpetrun5 mentioned this pull request Oct 2, 2023
Merged
@nmlinaric nmlinaric deleted the mpetrun5/address-whitelist branch October 10, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmlinaric nmlinaric nmlinaric approved these changes

@MakMuftic MakMuftic MakMuftic approved these changes

@viatrix viatrix viatrix approved these changes

@lastperson lastperson Awaiting requested review from lastperson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement fee whitelist
5 participants
@mpetrun5 @lastperson @MakMuftic @viatrix @nmlinaric