Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: limit permissionless generic call gas usage #200

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

mpetrun5
Copy link
Collaborator

@mpetrun5 mpetrun5 commented Sep 19, 2023

Previously, we had maxFee field for this purpose, but we didn't use and mistakenly thought we couldn't for the purpose of limiting generic call gas usage which prevented us of batching them.
This uses that value for that purpose.

Description

Related Issue Or Context

Closes: #199
Closes: #201

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

Copy link
Contributor

@nmlinaric nmlinaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lastperson
Copy link
Contributor

Any rationale why is it called fee and not gas ?

@mpetrun5
Copy link
Collaborator Author

mpetrun5 commented Sep 28, 2023

Any rationale why is it called fee and not gas ?

I think it was to reference that the destination might not be Evm and to not make it specific towards that.

@mpetrun5 mpetrun5 merged commit d7823d7 into master Oct 2, 2023
5 checks passed
@mpetrun5 mpetrun5 deleted the mpetrun5/limit-generic-call-gas branch July 22, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set maximum fee on the permissionless generic handler Limit gas for permissionless generic calls
4 participants