build: abstract out shared library suffix

PR-URL: nodejs#7687 Ref: nodejs#9385 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> The build system currently creates a shared library on OS X with the same name as on Linux i.e. libnode.so.48. This is inconsistent with the conventions on OS X which uses libnode.48.dylib This commit changes the build process and install.py (used by make binary) to build with the correct name on OS X when the --shared configure parameter is used. PR-URL: nodejs#7687 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
sxa · Nov 16, 2016 · 53e74fe · 53e74fe
1 parent c5f3e4e
commit 53e74fe
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/node.gyp b/node.gyp
@@ -236,7 +236,7 @@
          ],
           'conditions': [
             [ 'node_module_version!="" and OS!="win"', {
-              'product_extension': 'so.<(node_module_version)',
+              'product_extension': '<(shlib_suffix)',
             }]
           ],
         }],

diff --git a/tools/install.py b/tools/install.py
@@ -133,10 +133,11 @@ def files(action):
     if is_windows:
       output_file += '.dll'
     else:
-      # GYP will output to lib.target, this is hardcoded in its source,
-      # see the _InstallablaeTargetInstallPath function.
-      output_prefix += 'lib.target/'
-      output_file = 'lib' + output_file + '.so'
+      output_file = 'lib' + output_file + '.' + variables.get('shlib_suffix')
+      # GYP will output to lib.target except on OS X, this is hardcoded
+      # in its source - see the _InstallableTargetInstallPath function.
+      if sys.platform != 'darwin':
+        output_prefix += 'lib.target/'
 
   action([output_prefix + output_file], 'bin/' + output_file)