Skip to content

Commit

Permalink
[llvm-symbolizer] Add back --use-symbol-table=true
Browse files Browse the repository at this point in the history
It is used by clusterfuzz (google/clusterfuzz#2009)
and having this compatibility option for a while can help they do bisection
with the latest llvm-symbolizer.

Reviewed By: jhenderson

Differential Revision: https://reviews.llvm.org/D87067
  • Loading branch information
MaskRay committed Sep 3, 2020
1 parent 2b71b7f commit 3d54976
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
7 changes: 7 additions & 0 deletions llvm/test/tools/llvm-symbolizer/use-symbol-table.s
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# REQUIRES: x86-registered-target

# RUN: llvm-mc -filetype=obj -triple=x86_64 -g %s -o %t.o

## --use-symbol-table=true is used by old asan_symbolize.py and Android ndk
## ndk-stack.py. Keep it as a no-op compatibility option for a while.
# RUN: llvm-symbolizer --use-symbol-table=true %t.o
2 changes: 2 additions & 0 deletions llvm/tools/llvm-symbolizer/Opts.td
Original file line number Diff line number Diff line change
Expand Up @@ -67,3 +67,5 @@ def : Flag<["--"], "inlining=false">, Alias<no_inlines>, HelpText<"Alias for --n
// Compatibility aliases for pprof's symbolizer.
def : Flag<["-"], "demangle=true">, Alias<demangle>, HelpText<"Alias for --demangle">;
def : Flag<["-"], "demangle=false">, Alias<no_demangle>, HelpText<"Alias for --no-demangle">;
// Compatibility no-op options.
def : Flag<["--"], "use-symbol-table=true">;

0 comments on commit 3d54976

Please sign in to comment.