feat(problem): optimize endpoints (#47)

.changes/problem.md

@@ -0,0 +1,5 @@
+---
+"algohub-server": patch:feat
+---
+
+Optimize endpoints for problem updates.

Cargo.toml

@@ -12,8 +12,10 @@ license = "AGPL-3.0-only"
 [dependencies]
 anyhow = "1.0.92"
 chrono = { version = "0.4.38", features = ["serde"] }
-eval-stack = { version = "0.2.0", features = ["serde"] }
+eval-stack = { version = "0.3.1", default-features = false, features = [
+    "serde",
+] }
 rocket = { version = "0.5.1", features = ["json"] }
 serde = { version = "1.0.214", features = ["derive"] }
-surrealdb = "2.1.0"
+surrealdb = "2.1.2"
 uuid = { version = "1.11.0", features = ["v4"] }

src/models/asset.rs

@@ -27,6 +27,7 @@ pub struct CreateAsset<'a> {
 #[derive(Serialize, Deserialize)]
 pub struct UserContent {
     pub id: String,
+    pub name: String,
 }
 
 pub struct AssetFile(pub(crate) NamedFile);

src/models/problem.rs

@@ -116,6 +116,21 @@ impl From<CreateProblem<'_>> for Problem {
     }
 }
 
+#[derive(Debug, Clone, Serialize, Deserialize)]
+pub struct OwnedUserTestCase {
+    pub input: String,
+    pub output: String,
+}
+
+impl From<TestCase> for OwnedUserTestCase {
+    fn from(value: TestCase) -> Self {
+        OwnedUserTestCase {
+            input: value.input.id.to_string(),
+            output: value.output.id.to_string(),
+        }
+    }
+}
+
 #[derive(Debug, Deserialize, Serialize)]
 pub struct UserProblem {
     pub id: String,
@@ -129,6 +144,7 @@ pub struct UserProblem {
 
     pub time_limit: u64,
     pub memory_limit: u64,
+    pub test_cases: Vec<OwnedUserTestCase>,
 
     pub creator: String,
     pub owner: UserRecordId,
@@ -153,6 +169,7 @@ impl From<Problem> for UserProblem {
             hint: value.hint,
             time_limit: value.time_limit,
             memory_limit: value.memory_limit,
+            test_cases: value.test_cases.into_iter().map(Into::into).collect(),
             creator: value.creator.id.to_string(),
             owner: value.owner.into(),
             categories: value.categories,

src/models/submission.rs

@@ -18,7 +18,8 @@ pub struct Submission {
     pub problem: Thing,
     pub code: String,
     pub status: Status,
-    pub results: Vec<JudgeResult>,
+    pub judge_details: Vec<JudgeResult>,
+    pub judge_result: Option<JudgeResult>,
     pub creator: Thing,
     pub contest: Option<Thing>,
 

src/routes/asset.rs

@@ -24,9 +24,7 @@ pub async fn upload(
     data: Form<CreateAsset<'_>>,
 ) -> Result<UserContent> {
     if !session::verify(db, data.auth.id, data.auth.token).await {
-        return Err(Error::Unauthorized(Json(
-            "Failed to grant access permission".into(),
-        )));
+        return Err(Error::Unauthorized(Json("Invalid credentials".into())));
     }
 
     let file_extension = data
@@ -41,9 +39,7 @@ pub async fn upload(
         .join(data.auth.id);
 
     if !user_path.exists() {
-        create_dir_all(&user_path)
-            .await
-            .map_err(|e| Error::ServerError(Json(e.to_string().into())))?;
+        create_dir_all(&user_path).await?;
     }
     let file_name = format!("{}.{}", uuid::Uuid::new_v4(), file_extension);
     let file_path = user_path.join(&file_name);
@@ -61,22 +57,22 @@ pub async fn upload(
         .await
         .map_err(|e| Error::ServerError(Json(format!("Failed to save file: {}", e).into())))?;
 
-    let asset = asset::create(
-        db,
-        data.owner.clone(),
-        data.file
-            .name()
-            .unwrap_or(&uuid::Uuid::new_v4().to_string()),
-        file_path,
-    )
-    .await
-    .map_err(|e| Error::ServerError(Json(e.into())))?
-    .ok_or(Error::ServerError(Json("Failed to create asset".into())))?;
+    let asset_name = data
+        .file
+        .name()
+        .map(|name| name.to_string())
+        .unwrap_or(uuid::Uuid::new_v4().to_string());
+
+    let asset = asset::create(db, data.owner.clone(), &asset_name, file_path)
+        .await?
+        .ok_or(Error::ServerError(Json("Failed to create asset".into())))?;
+
     Ok(Json(Response {
         success: true,
         message: "Content updated successfully".into(),
         data: Some(UserContent {
             id: asset.id.unwrap().id.to_string(),
+            name: asset_name,
         }),
     }))
 }
@@ -88,26 +84,23 @@ pub async fn get(db: &State<Surreal<Client>>, id: &str) -> Option<AssetFile> {
     Some(AssetFile(NamedFile::open(&asset.path).await.ok()?))
 }
 
-#[post("/delete/<id>", data = "<auth>")]
+#[delete("/delete/<id>", data = "<auth>")]
 pub async fn delete(
     db: &State<Surreal<Client>>,
     id: &str,
-    auth: Form<Credentials<'_>>,
+    auth: Json<Credentials<'_>>,
 ) -> Result<Empty> {
     if !session::verify(db, auth.id, auth.token).await {
-        return Err(Error::Unauthorized(Json(
-            "Failed to grant access permission".into(),
-        )));
+        return Err(Error::Unauthorized(Json("Invalid credentials".into())));
     }
 
     let asset = asset::get_by_id(db, id)
-        .await
-        .map_err(Error::from)?
+        .await?
         .ok_or(Error::NotFound(Json("Asset not found".into())))?;
 
-    rocket::tokio::fs::remove_file(&asset.path)
-        .await
-        .map_err(|e| Error::ServerError(Json(format!("Failed to delete file: {}", e).into())))?;
+    let _ = rocket::tokio::fs::remove_file(&asset.path).await;
+
+    asset::delete(db, id).await?;
 
     Ok(Json(Response {
         success: true,

src/routes/problem.rs

@@ -148,6 +148,30 @@ pub async fn list(
     }))
 }
 
+#[post("/update/<id>", data = "<problem>")]
+pub async fn update(
+    db: &State<Surreal<Client>>,
+    id: &str,
+    problem: Json<CreateProblem<'_>>,
+) -> Result<Empty> {
+    if !session::verify(db, problem.id, problem.token).await {
+        return Err(Error::Unauthorized(Json("Invalid credentials".into())));
+    }
+
+    problem::update(db, id, problem.into_inner())
+        .await
+        .map_err(|e| Error::ServerError(Json(e.to_string().into())))?
+        .ok_or(Error::ServerError(Json(
+            "Failed to update problem, please try again later.".into(),
+        )))?;
+
+    Ok(Json(Response {
+        success: true,
+        message: "Problem updated successfully".to_string(),
+        data: None,
+    }))
+}
+
 #[delete("/delete/<id>", data = "<auth>")]
 pub async fn delete(
     db: &State<Surreal<Client>>,
@@ -177,5 +201,5 @@ pub async fn delete(
 
 pub fn routes() -> Vec<rocket::Route> {
     use rocket::routes;
-    routes![create, get, list, delete]
+    routes![create, get, update, list, delete]
 }