feat(problem): support delete problem and assets (#43)

* feat(problem): support delete problem and assets

* chore: fix test db port

* chore: remove serde_json

.changes/problem.md

@@ -0,0 +1,5 @@
+---
+"algohub-server": patch:feat
+---
+
+Add endpoint to delete a problem by specified problem ID.

src/cors.rs

@@ -8,7 +8,7 @@ pub struct CORS;
 impl Fairing for CORS {
     fn info(&self) -> Info {
         Info {
-            name: "Add CORS headers to responses",
+            name: "CORS Policy",
             kind: Kind::Response,
         }
     }

src/main.rs

@@ -1,6 +1,12 @@
+use algohub_server::routes::index::init_db;
 use rocket::launch;
 
 #[launch]
 async fn rocket() -> _ {
-    algohub_server::rocket().await
+    algohub_server::rocket(
+        init_db("localhost:5177")
+            .await
+            .expect("Failed to initialize database, shutting down..."),
+    )
+    .await
 }

src/models/problem.rs

@@ -163,3 +163,9 @@ impl From<Problem> for UserProblem {
         }
     }
 }
+
+#[derive(Debug, Clone, Serialize, Deserialize)]
+pub struct ServerTestCase {
+    pub input: String,
+    pub output: String,
+}

src/routes/index.rs

@@ -9,6 +9,7 @@ use super::submission;
 use crate::{cors::CORS, routes::account};
 use anyhow::Result;
 use rocket::fs::NamedFile;
+use surrealdb::engine::remote::ws::Client;
 use surrealdb::{engine::remote::ws::Ws, opt::auth::Root, Surreal};
 
 #[get("/")]
@@ -21,10 +22,11 @@ async fn files(file: PathBuf) -> Option<NamedFile> {
     NamedFile::open(Path::new("dist/").join(file)).await.ok()
 }
 
-pub async fn rocket() -> rocket::Rocket<rocket::Build> {
-    let db = Surreal::new::<Ws>("127.0.0.1:5176")
+pub async fn init_db(db_addr: &str) -> Result<Surreal<Client>> {
+    let db = Surreal::new::<Ws>(db_addr)
         .await
         .expect("Failed to connect to database");
+
     db.use_ns("main")
         .use_db("acm")
         .await
@@ -36,6 +38,10 @@ pub async fn rocket() -> rocket::Rocket<rocket::Build> {
     .await
     .expect("Failed to authenticate");
 
+    Ok(db)
+}
+
+pub async fn rocket(db: Surreal<Client>) -> rocket::Rocket<rocket::Build> {
     rocket::build()
         .attach(CORS)
         .mount("/", routes![index, files])

src/routes/problem.rs

@@ -1,4 +1,4 @@
-use rocket::{serde::json::Json, State};
+use rocket::{serde::json::Json, tokio::fs::remove_file, State};
 use serde::{Deserialize, Serialize};
 use surrealdb::{engine::remote::ws::Client, Surreal};
 
@@ -7,7 +7,7 @@ use crate::{
         account::Account,
         error::Error,
         problem::{CreateProblem, Problem, ProblemVisibility, UserProblem},
-        response::Response,
+        response::{Empty, Response},
         Credentials, OwnedCredentials, OwnedId,
     },
     utils::{account, problem, session},
@@ -148,7 +148,34 @@ pub async fn list(
     }))
 }
 
+#[delete("/delete/<id>", data = "<auth>")]
+pub async fn delete(
+    db: &State<Surreal<Client>>,
+    id: &str,
+    auth: Json<Credentials<'_>>,
+) -> Result<Empty> {
+    if !session::verify(db, auth.id, auth.token).await {
+        return Err(Error::Unauthorized(Json("Invalid credentials".into())));
+    }
+
+    for test_case in problem::get_test_cases_by_id(db, id).await? {
+        remove_file(test_case.input).await?;
+        remove_file(test_case.output).await?;
+    }
+    println!("Down");
+
+    problem::delete(db, id).await?.ok_or(Error::NotFound(Json(
+        "Problem with specified id not found".into(),
+    )))?;
+
+    Ok(Json(Response {
+        success: true,
+        message: "Problem deleted successfully".to_string(),
+        data: None,
+    }))
+}
+
 pub fn routes() -> Vec<rocket::Route> {
     use rocket::routes;
-    routes![create, get, list]
+    routes![create, get, list, delete]
 }

src/utils/problem.rs

@@ -1,8 +1,8 @@
 use anyhow::Result;
 use serde::Deserialize;
-use surrealdb::{engine::remote::ws::Client, Surreal};
+use surrealdb::{engine::remote::ws::Client, sql::Thing, Surreal};
 
-use crate::models::problem::{CreateProblem, Problem};
+use crate::models::problem::{CreateProblem, Problem, ServerTestCase};
 
 pub async fn create(db: &Surreal<Client>, problem: CreateProblem<'_>) -> Result<Option<Problem>> {
     Ok(db
@@ -21,8 +21,20 @@ pub async fn update(db: &Surreal<Client>, problem: Problem) -> Result<Option<Pro
         .await?)
 }
 
+const DELETE_ALL_ASSETS_QUERY: &str = r#"
+IF $problem.exists() {
+    FOR $asset IN (SELECT VALUE test_cases FROM $problem) {
+        DELETE $asset.input, $asset.output;
+    };
+    (DELETE ONLY $problem RETURN BEFORE)
+}
+"#;
 pub async fn delete(db: &Surreal<Client>, id: &str) -> Result<Option<Problem>> {
-    Ok(db.delete(("problem", id)).await?)
+    Ok(db
+        .query(DELETE_ALL_ASSETS_QUERY)
+        .bind(("problem", Thing::from(("problem", id))))
+        .await?
+        .take(0)?)
 }
 
 pub async fn get<M>(db: &Surreal<Client>, id: &str) -> Result<Option<M>>
@@ -68,3 +80,18 @@ where
 
     Ok(response.take(0)?)
 }
+
+const SELECT_TEST_CASES_QUERY: &str = r#"
+IF $problem.exists() THEN
+    SELECT input.path AS input, output.path AS output FROM $problem.test_cases
+ELSE
+    []
+END;
+"#;
+pub async fn get_test_cases_by_id(db: &Surreal<Client>, id: &str) -> Result<Vec<ServerTestCase>> {
+    Ok(db
+        .query(SELECT_TEST_CASES_QUERY)
+        .bind(("problem", Thing::from(("problem", id))))
+        .await?
+        .take(0)?)
+}

tests/1.in

@@ -0,0 +1 @@
+1 2

tests/1.out

@@ -0,0 +1 @@
+3

tests/account.rs

@@ -10,11 +10,11 @@ use algohub_server::models::{
 };
 use anyhow::Result;
 use rocket::{http::ContentType, local::asynchronous::Client};
-use utils::Upload;
+use utils::{rocket, Upload};
 
 #[rocket::async_test]
 async fn test_register() -> Result<()> {
-    let rocket = algohub_server::rocket().await;
+    let rocket = rocket().await;
 
     let client = Client::tracked(rocket).await?;
 

tests/category.rs

@@ -1,3 +1,5 @@
+mod utils;
+
 use algohub_server::models::{
     account::Register,
     category::{Category, CategoryData, CreateCategory, ListCategories},
@@ -6,10 +8,11 @@ use algohub_server::models::{
 };
 use anyhow::Result;
 use rocket::local::asynchronous::Client;
+use utils::rocket;
 
 #[rocket::async_test]
 async fn test_category() -> Result<()> {
-    let rocket = algohub_server::rocket().await;
+    let rocket = rocket().await;
     let client = Client::tracked(rocket).await?;
 
     println!("Testing category...");

tests/organization.rs

@@ -1,3 +1,5 @@
+mod utils;
+
 use std::path::Path;
 
 use algohub_server::models::{
@@ -8,10 +10,11 @@ use algohub_server::models::{
 };
 use anyhow::Result;
 use rocket::local::asynchronous::Client;
+use utils::rocket;
 
 #[rocket::async_test]
 async fn test_organization() -> Result<()> {
-    let rocket = algohub_server::rocket().await;
+    let rocket = rocket().await;
 
     let client = Client::tracked(rocket).await?;