validate pubkey from extended public key when parsed; validate extended key version #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scgbckbone
commented
Jul 18, 2025
There was a problem hiding this comment.
fixed here:
- we allow to de-serialize extended public key that contains private key and vice-versa (we haven't checked the version vs data inside)
- we allow to de-serialize extended public that contains invalid secp256k1 pubkey, for example
020000000000000000000000000000000000000000000000000000000000000007(not a security issue here as invalid pubkey would raise exception when we start working with it, but this imo should be part of validation logic)
…ed key has proper version wrt data it carries
scgbckbone
force-pushed
the
more_validation_on_deserialize
branch
from
05cf33d to
52c8e7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.