fix ESCAPE_RE regular expression #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swistakm
requested changes
Feb 9, 2017
| assert str( | ||
| Proximity(Value("foo bar", safe=True), 12, safe=True) | ||
| ) == '"foo bar"~12' | ||
|
|
There was a problem hiding this comment.
Add additional new line to satisfy pep8 checks
|
|
||
| def test_can_escape_special_characters(): | ||
| assert str(Q(foo="\\")) == "foo:\\\\" | ||
|
|
There was a problem hiding this comment.
Add additional new line to satisfy pep8 checks
Make it match a single backslash character. Test that it matches a single backslash. Remove Proximity(Value()): they cannot be equal, because the space will be escaped in the instanciation of Value, and the backslash used to escape the space will then be escaped in Proximity.
|
Thanks for the review. I updated my branch. |
|
Thanks! I will create new realease in the beginning of the next week when I resolve pypy build issue on travis. |
|
Released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it match a single backslash character. Test that it matches a
single backslash. Remove Proximity(Value()): they cannot be equal,
because the space will be escaped in the instanciation of Value, and the
backslash used to escape the space will then be escaped in Proximity.