Skip to content

Range: add boundaries argument to support explicit range boundaries #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 7, 2016
Merged

Range: add boundaries argument to support explicit range boundaries #2

merged 2 commits into from
Sep 7, 2016

Conversation

@swistakm
Copy link
Owner

@swistakm swistakm commented Sep 6, 2016

Example usage:

>>> Range(0, 20, boundaries='exclusive')
<Range: {0 TO 20}>
>>> Range(0, 20, boundaries='ei')
<Range: {0 TO 20]>
>>> Range(0, 20, boundaries='[}')
<Range: [0 TO 20}>

More details in updated docstring.

@swistakm
Copy link
Owner Author

swistakm commented Sep 6, 2016

@mihau, @momirjalili please take a look and comment.

@coveralls
Copy link

coveralls commented Sep 6, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling a10d8ff on feature/explicit-range-boundaries into c62a755 on master.

mihau
mihau reviewed Sep 6, 2016
View reviewed changes
src/solrq/__init__.py Outdated
Wraps two values with Solr's ``[<from> TO <to>]`` syntax with respect to
restricted character esaping.
Wrapper around range values. Wraps two values with Solr's
Copy link

@mihau mihau Sep 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment seems duplicated.

@mihau
Copy link

mihau commented Sep 6, 2016

Looks good - seems easy to work with.

@momirjalili
Copy link

momirjalili commented Sep 6, 2016

looks good to me, straight forward and simple.

@swistakm swistakm merged commit 68ca6ba into master Sep 7, 2016
@swistakm swistakm deleted the feature/explicit-range-boundaries branch September 7, 2016 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@swistakm @coveralls @mihau @momirjalili