Skip to content

PR for release #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jan 6, 2025
Merged

PR for release #624

merged 17 commits into from
Jan 6, 2025

Conversation

mcweba
Copy link
Collaborator

@mcweba mcweba commented Jan 6, 2025

No description provided.

runner and others added 17 commits December 9, 2024 15:27
…d the request. The reason is that the pump starts writing the upstream request before the #send() method is actually called, and if the server side already answers to that before we call #send(), we would have no handler installed yet.
…r_metricName

#621 Added metric to circuit breaker entries
Feature/issue615 provide circuit breaker metrics
…warder-called-twice-per-request

Bug 618 response handler in forwarder called twice per request
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 85.41667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 49.23%. Comparing base (110c4af) to head (dc6591d).
Report is 82 commits behind head on master.

Files with missing lines Patch % Lines
...onitoring/QueueCircuitBreakerMetricsCollector.java 91.66% 2 Missing and 4 partials ⚠️
...ing/circuitbreaker/util/PatternAndCircuitHash.java 50.00% 1 Missing and 3 partials ⚠️
...java/org/swisspush/gateleen/routing/Forwarder.java 0.00% 3 Missing ⚠️
...tbreaker/impl/RedisQueueCircuitBreakerStorage.java 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #624      +/-   ##
============================================
+ Coverage     48.44%   49.23%   +0.78%     
- Complexity     1862     1934      +72     
============================================
  Files           238      239       +1     
  Lines         11953    12198     +245     
  Branches       1261     1308      +47     
============================================
+ Hits           5791     6006     +215     
- Misses         5659     5660       +1     
- Partials        503      532      +29     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcweba mcweba merged commit 9bc4263 into master Jan 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants