fix(ep): guard CXI libfabric include - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Guard the CXI-only
rdma/fi_atomic.hinclude behindUSE_LIBFABRIC_CXI.Why
The upstream CXI PR currently fails the AMD/non-CXI build because
ep/src/cxi_transport.cppincludes a libfabric header unconditionally. Onmachines without libfabric development headers, the generated
cxi_transport_hip.cppfails with:cxi_transport.hppalready guards its libfabric headers behindUSE_LIBFABRIC_CXI; this applies the same rule to the atomic header in theimplementation file.
Validation
clang-formatonep/src/cxi_transport.cpp.git diff --check.