Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery Icon Support #129

Closed
patrickhousley opened this issue Mar 27, 2013 · 2 comments
Closed

jQuery Icon Support #129

patrickhousley opened this issue Mar 27, 2013 · 2 comments
Labels

Comments

@patrickhousley
Copy link

jQuery UI has a great selection of icons that could be used with the menu entries. However, your plugin does not support these icons out of the box. I have included the changes I make below in hopes of having this as the default icon support in this plugin.

line 1078 change if block to:

// add icons
if (item.icon) {
     $('<span></span>', {
          'class' : 'ui-icon ui-icon-' + item.icon,
     }).prependTo($t);
}
@rodneyrehm
Copy link
Contributor

Yes, and someone else might prefer to actually use an <img>. For that reason I've decided to add a configurable iconHook (being an overwritable callback) that anyone can modify to their liking. I'll keep this issue open as a reference…

@bbrala
Copy link
Member

bbrala commented Aug 30, 2015

Fixed by craeting a callback option as icon value for an item. See #272

@bbrala bbrala closed this as completed Aug 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants