Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky package dependency tests #1258

Open
award999 opened this issue Dec 10, 2024 · 0 comments
Open

Flaky package dependency tests #1258

award999 opened this issue Dec 10, 2024 · 0 comments
Labels
needs verification Issue has been fixed, but requires verification before closing testing infrastructure Issues related to CI jobs or extension test cases

Comments

@award999
Copy link
Contributor

Some package dependency tests are flaky in CI

  1) PackageDependencyProvider Test Suite
       Includes local dependency:
     AssertionError: Expected to find defaultPackage, but instead items were swift-cmark,swift-markdown: expected undefined not to be undefined
      at Context.<anonymous> (d:\a\vscode-swift\vscode-swift\test\integration-tests\ui\PackageDependencyProvider.test.ts:65:20)

  2) PackageDependencyProvider Test Suite
       Lists local dependency file structure:
     AssertionError: Expected to find defaultPackage, but instead items were swift-cmark,swift-markdown: expected undefined not to be undefined
      at Context.<anonymous> (d:\a\vscode-swift\vscode-swift\test\integration-tests\ui\PackageDependencyProvider.test.ts:77:20)
@award999 award999 added the testing infrastructure Issues related to CI jobs or extension test cases label Dec 10, 2024
@award999 award999 self-assigned this Dec 11, 2024
@award999 award999 moved this from Unscreened to Todo in Swift Extension for Visual Studio Code Dec 11, 2024
award999 added a commit to award999/vscode-swift that referenced this issue Dec 19, 2024
@award999
Fix flaky package dependency tests
acc71ea 
* Seem to be intermittent failures if defaultPackage was not in the
  the workspace context as a package folder so lets be explicit

Issue: swiftlang#1258
award999 added a commit to award999/vscode-swift that referenced this issue Dec 19, 2024
@award999
Fix flaky package dependency tests
f80710e 
* Seem to be intermittent failures if defaultPackage was not in the
  the workspace context as a package folder so lets be explicit

Issue: swiftlang#1258
@award999 award999 mentioned this issue Dec 19, 2024
Merged
@award999 award999 moved this from Todo to In Progress in Swift Extension for Visual Studio Code Dec 19, 2024
plemarquand pushed a commit that referenced this issue Dec 19, 2024
@award999
Fix flaky package dependency tests (#1288)
ea16da0 
* Seem to be intermittent failures if defaultPackage was not in the
  the workspace context as a package folder so lets be explicit

Issue: #1258
@award999 award999 moved this from In Progress to Needs Verification in Swift Extension for Visual Studio Code Dec 20, 2024
@award999 award999 removed their assignment Dec 20, 2024
@award999 award999 added the needs verification Issue has been fixed, but requires verification before closing label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs verification Issue has been fixed, but requires verification before closing testing infrastructure Issues related to CI jobs or extension test cases
Projects
Swift Extension for Visual Studio Code
Status: Needs Verification
Milestone
No milestone
Development

No branches or pull requests
1 participant
@award999