[Concurrency] WIP: Rework task_switch with task executors, don't enqueue unless necessary #85191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly right but sometimes hitting a lockup somewhere that I was not able to figure out yet. This needs much cleanup and is mostly for sharing Work in Progress for discussion right now.
ktoso
commented
Oct 29, 2025
| // ABI Note: We need to use @abi here because the ABI of this function otherwise conflicts with the legacy | ||
| // @_unsafeInheritExecutor declaration, as none of them have (or mangle) the implicit | ||
| @abi( | ||
| nonisolated(nonsending) func withCheckedContinuationNonisolatedNonsending<T>( |
ktoso
commented
Oct 29, 2025
| #define SWIFT_TASK_DEBUG_LOG_ENABLED 1 | ||
| #define SWIFT_TASK_DEBUG_LOG(fmt, ...) \ | ||
| fprintf(stderr, "[%#lx] [%s:%d](%s) " fmt "\n", \ | ||
| fprintf(stdout, "[%#lx] [%s:%d](%s) " fmt "\n", \ |
Contributor
Author
There was a problem hiding this comment.
FIXME: just for debugging, undo this
ktoso
changed the title
Contributor
Author
|
@swift-ci please smoke test |
ktoso
force-pushed
the
wip-fix-task-AND-serial-executor
branch
from
0407798 to
79bc38a
Compare
FranzBusch
reviewed
Oct 29, 2025
Comment on lines
+2603
to
+2606
| TaskExecutorRef currentTaskExecutor = (trackingInfo ? trackingInfo->getTaskExecutor() | ||
| : TaskExecutorRef::undefined()); | ||
| if (!trackingInfo) SWIFT_TASK_DEBUG_LOG("Missing executor tracking, assume currentTaskExecutor = %s.", "undefined"); | ||
| TaskExecutorRef newTaskExecutor = task->getPreferredTaskExecutor(); |
Member
There was a problem hiding this comment.
I might have missed this and it is solved differently but are we still keeping track of the default executors as part of the tracking info? In particular, our default executor are conforming to TaskExecutor and they will call runSynchronously with the TaskExecutor overload. I want to be sure that if there is only a custom default executor, no isolation and no task executor preference that we are also hitting the fast path.
Contributor
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly right but sometimes hitting a lockup somewhere that I was not able to figure out yet.
This needs much cleanup and is mostly for sharing Work in Progress for discussion right now.
Work in progress table of behaviors