-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[ClangImporter] Fix Build Break Due to clang API changes
#84925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@swift-ci please smoke test. |
|
@swift-ci please test Windows |
|
@swift-ci please smoke test. |
|
@swift-ci please test Windows |
|
@swift-ci please smoke test. |
|
@swift-ci please test Windows |
|
@swift-ci please smoke test. |
|
The macOS failure could be dependency scanning related (https://ci.swift.org/job/swift-PR-macos-smoke-test/23721/consoleFull). Specifically, the error is |
|
Probably similar to #84995? |
|
@swift-ci Please clean smoke test macOS platform |
|
swiftlang/llvm-project#11631 |
|
https://ci.swift.org/job/swift-PR-macos-smoke-test/23793/ @jansvoboda11 I think I saw this similar error when trying to run smoke tests. Do I need to rebase my branch diff on the new |
|
@vanvoorden I think one of my PRs introduced a bug. I have reverts here: swiftlang/llvm-project#11670 #85051 |
|
@jansvoboda11 I rebased my diff yesterday in the morning on main but I still saw smoke test failures… were there any new diffs that landed that might help? |
|
Does your branch contain the reverts mentioned above? I'm not aware of other commits you'd need to fix the issue. |
|
@jansvoboda11 Yes I rebased from yesterday which should have included the reverts. Hmm… are these smoke test jobs generally just flaky to begin with? |
swiftlang/llvm-project#11631 is cherry-picking
clangcommits that changeCompilerInstance's APIs. The API changes are causing Swift build breaks. This PR fixes the API breaks.