Sema: Workaround for broken existential opening behavior #84501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a narrow workaround for a regression from 9e3d0e0. There is no reason to skip this logic for protocol extension members, except that doing so happens to break existential opening in an expression that involves a call to Array.init elsewhere. However there is an underlying issue here with existential opening, which doesn't seem to work right in the presence of overloading. The test case demonstrates the fixed problem, together with an existing bug that points to the underlying problem. Fixes rdar://160389221.
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
Author
|
@swift-ci Please test source compatibility |
xedin
approved these changes
Sep 25, 2025
Contributor
Author
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a narrow workaround for a regression from
9e3d0e0.
There is no reason to skip this logic for protocol extension members, except that doing so happens to break existential opening in an expression that involves a call to Array.init elsewhere.
However there is an underlying issue here with existential opening, which doesn't seem to work right in the presence of overloading.
The test case demonstrates the fixed problem, together with an existing bug that points to the underlying problem.
Fixes rdar://160389221.