[cxx-interop] Allow old spelling of AppKit constants #83568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AppKit defines certain constants in Objective-C, and then renames them into different constants in Swift, e.g. `NSUpArrowFunctionKey` is renamed into `NSEvent.SpecialKey.upArrow.rawValue`. In addition to that, AppKit also re-defines these constants in pure-Swift, which isn't the intended mechanism for renaming such constants. Prior to llvm/llvm-project#145947, Clang was silently dropping the `SwiftName` API Notes attributes on these constants due to a bug in the name validation mechanism. Clients of AppKit relied on that behavior and continued to use the old spelling in Swift. To preserve source compatibility and avoid a deprecation error, let's continue dropping the `SwiftName` attribute on select constants from AppKit. rdar://157485334
egorzhdan
requested review from
beccadax,
fahadnayyar,
hnrklssn,
ian-twilightcoder and
susmonteiro
as code owners
Contributor
Author
|
@swift-ci please test |
ktoso
approved these changes
Aug 6, 2025
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
@swift-ci please test macOS |
Contributor
|
@swift-ci please test Windows |
Xazax-hun
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AppKit defines certain constants in Objective-C, and then renames them into different constants in Swift, e.g.
NSUpArrowFunctionKeyis renamed intoNSEvent.SpecialKey.upArrow.rawValue.In addition to that, AppKit also re-defines these constants in pure-Swift, which isn't the intended mechanism for renaming such constants.
Prior to llvm/llvm-project#145947, Clang was silently dropping the
SwiftNameAPI Notes attributes on these constants due to a bug in the name validation mechanism. Clients of AppKit relied on that behavior and continued to use the old spelling in Swift. To preserve source compatibility and avoid a deprecation error, let's continue dropping theSwiftNameattribute on select constants from AppKit.rdar://157485334