Correctly forward the implicit nonisolated(nonsending) parameter in thunks
#82705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Please test |
tshortli
approved these changes
Jul 2, 2025
Contributor
Author
|
What |
Contributor
Author
|
@swift-ci Please test |
SILGen thunks. Also, I discovered that we don't apply nonisolated(nonsending) to function types in the new mode. That's one for a different patch. Fixes rdar://154401813
rjmccall
force-pushed
the
nonisolated-nonsending-thunks
branch
from
51a9583 to
c1d153c
Compare
Contributor
Author
|
@swift-ci Please test |
Contributor
Author
|
@swift-ci Please test macOS |
1 similar comment
Contributor
Author
|
@swift-ci Please test macOS |
DougGregor
approved these changes
Jul 2, 2025
Contributor
|
@swift-ci Please test macOS |
1 similar comment
Contributor
Author
|
@swift-ci Please test macOS |
Contributor
Author
|
@swift-ci Please test |
Contributor
Author
|
@swift-ci Please test macOS |
Contributor
Author
|
@swift-ci Please test Windows |
Contributor
Author
|
@swift-ci Please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, I discovered that we don't apply nonisolated(nonsending) to function types in the new mode. That's one for a different patch.
Fixes rdar://154401813 and rdar://154137740