Skip to content

[Stdlib] Optimize CollectionType.first #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dabrahams merged 1 commit into from
Jan 1, 2016
Merged

[Stdlib] Optimize CollectionType.first #825

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion stdlib/public/core/Collection.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,12 @@ extension CollectionType {
///
/// - Complexity: O(1)
public var first: Generator.Element? {
return isEmpty ? nil : self[startIndex]
// NB: Accessing `startIndex` may not be O(1) for some lazy collections,
// so instead of testing `isEmpty` and then returning the first element,
// we'll just rely on the fact that the generator always yields the
// first element first.
var gen = generate()
return gen.next()
}

/// Returns a value less than or equal to the number of elements in
Expand Down