[6.2] MandatoryPerformanceOptimizations: only set the [perf_constraint] flag for callees of performance constraint functions
#82141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lag for callees of performance constraint functions It used to also set it for functions which are referenced from a global with a const/section attribute - even if not performance attribute was present in the whole module. This is unnecessary and can lead to worse code generation. rdar://152665294
xedin
approved these changes
Jun 10, 2025
Contributor
Author
|
@swift-ci test |
tbkka
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node::Kind::OutlinedInitializeWithTakeNoValueWitness#82066. Even without this original fix, no such SIL should be generated (which can cause the IRGen crash) in the first place. The[perf_constraint]flag should not be set to any function which is not - or not called - by a performance-constraint function. This fixes a regression which was introduced by [6.2] MandatoryPerformanceOptimizations: make sure to handle de-serialized vtable methods #81974.@_sectionor@constattribute..[perf_constraint]flag for callees of performance constraint functions #82068