[Concurrency] Bring back ability to get a queue custom executor in executorForEnqueuedJob #81198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecutorForEnqueuedJob This was a regression and now even if we had a queue set in job->SchedulerPrivate[Job::DispatchQueueIndex]. Arguably the way we're using that storage needs to be fixed somehow, since if we're opening this storage to other executors then it means we could have OTHER things in there, not just a dispatch queueue, and therefore this cast would be bad. For now though we can bring back the existing behavior while we work out with Alastair what the right way to handle this will be -- some marker bit somewhere that indeed this is a queue stored here? resolves rdar://150213107
Contributor
Author
|
Replaced by #81201 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a regression and now even if we had a queue set in
job->SchedulerPrivate[Job::DispatchQueueIndex].
Arguably the way we're using that storage needs to be fixed somehow,
since if we're opening this storage to other executors then it means
we could have OTHER things in there, not just a dispatch queueue,
and therefore this cast would be bad.
For now though we can bring back the existing behavior while we work out
with Alastair what the right way to handle this will be -- some marker
bit somewhere that indeed this is a queue stored here?
This was accidentally removed in 8b15b05#diff-d90051c83a2c096660ba71209df0910583b57e96b23f0135533f425c49a9baacL384-L390
resolves rdar://150213107