Skip to content

[DNM] Rebranch testing #81190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[DNM] Rebranch testing #81190

wants to merge 1 commit into from

Conversation

@AnthonyLatsis
Copy link
Collaborator

@AnthonyLatsis AnthonyLatsis commented Apr 30, 2025

No description provided.

@AnthonyLatsis AnthonyLatsis requested a review from bnbarham April 30, 2025 06:54
bnbarham
bnbarham reviewed Apr 30, 2025
View reviewed changes
@AnthonyLatsis

This comment was marked as duplicate.

Sign in to view
aschwaighofer
aschwaighofer approved these changes May 2, 2025
View reviewed changes
Copy link
Contributor

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you

@bnbarham
Copy link
Contributor

bnbarham commented May 2, 2025

@aschwaighofer do we actually care about checking for captures(none) and nuw? I mostly ask because it would be nice if we could avoid main conflicts here, which we could do if we used {{.*}} rather than the actual checks.

@AnthonyLatsis AnthonyLatsis mentioned this pull request May 4, 2025
Merged
@AnthonyLatsis AnthonyLatsis changed the title [rebranch] Adjust some tests to pass again [DNM] [rebranch] Adjust some tests to pass again May 4, 2025
adrian-prantl
adrian-prantl reviewed May 5, 2025
View reviewed changes
test/DebugInfo/shadowcopy-linetable.swift Outdated
@@ -24,7 +24,7 @@ func foo(_ x: inout Int64) {
// IRCHECK-NEXT: call void @llvm.memset.{{.*}}(ptr align {{(4|8)}} %[[X]], i8 0
// IRCHECK: store ptr %0, ptr %[[X]], align {{(4|8)}}
// IRCHECK-SAME: !dbg ![[LOC0:.*]]
// IRCHECK-NEXT: %[[VALUE:.*]] = getelementptr inbounds %Ts5Int64V, ptr %0, i32 0, i32 0,
// IRCHECK-NEXT: %[[VALUE:.*]] = getelementptr inbounds nuw %Ts5Int64V, ptr %0, i32 0, i32 0,
Copy link
Contributor

@adrian-prantl adrian-prantl May 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AnthonyLatsis AnthonyLatsis force-pushed the rebranch-fix-tests branch 2 times, most recently from f36c739 to 5e79ea5 Compare May 8, 2025 08:14
@AnthonyLatsis AnthonyLatsis mentioned this pull request May 8, 2025
Merged
@AnthonyLatsis AnthonyLatsis changed the title [DNM] [rebranch] Adjust some tests to pass again [DNM] [rebranch] Adjust some tests to pass again (part 2) May 8, 2025
@AnthonyLatsis AnthonyLatsis force-pushed the rebranch-fix-tests branch 3 times, most recently from a008ec9 to 20d38f9 Compare May 9, 2025 14:34
@AnthonyLatsis AnthonyLatsis marked this pull request as draft May 20, 2025 17:57
@AnthonyLatsis AnthonyLatsis changed the title [DNM] [rebranch] Adjust some tests to pass again (part 2) [DNM] Rebranch testing Jun 27, 2025
@AnthonyLatsis AnthonyLatsis force-pushed the rebranch-fix-tests branch 2 times, most recently from d453481 to d3f10ef Compare September 15, 2025 22:58
@AnthonyLatsis AnthonyLatsis reopened this Sep 16, 2025
@AnthonyLatsis AnthonyLatsis force-pushed the rebranch-fix-tests branch 16 times, most recently from cd8ae01 to 501cd8e Compare September 21, 2025 07:51
@AnthonyLatsis AnthonyLatsis mentioned this pull request Sep 21, 2025
Merged
@AnthonyLatsis AnthonyLatsis force-pushed the rebranch-fix-tests branch 2 times, most recently from 3bc7408 to 87413a5 Compare September 25, 2025 06:52
@AnthonyLatsis AnthonyLatsis mentioned this pull request Sep 25, 2025
Merged
@AnthonyLatsis
Copy link
Collaborator Author

AnthonyLatsis commented Sep 28, 2025

swiftlang/llvm-project#11515

@swift-ci please test

@AnthonyLatsis
Copy link
Collaborator Author

AnthonyLatsis commented Oct 1, 2025

@swift-ci please test macOS

@shahmishal shahmishal deleted the branch swiftlang:rebranch October 3, 2025 03:17
@shahmishal shahmishal closed this Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnbarham bnbarham bnbarham left review comments

@adrian-prantl adrian-prantl adrian-prantl left review comments

@aschwaighofer aschwaighofer aschwaighofer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@AnthonyLatsis @bnbarham @Xazax-hun @compnerd @adrian-prantl @aschwaighofer @shahmishal