[6.2][Concurrency] Add Hashable conformance to Async(Throwing)Stream.Continuation #81064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix failing test/api-digester/stability-concurrency-abi.test
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test macOS |
Contributor
Author
|
@swift-ci please test source compatibility |
Contributor
Author
|
@swift-ci please test macOS |
2 similar comments
Contributor
Author
|
@swift-ci please test macOS |
Contributor
Author
|
@swift-ci please test macOS |
DougGregor
approved these changes
Apr 25, 2025
Member
DougGregor
left a comment
DougGregor
left a comment
There was a problem hiding this comment.
LGTM, we can do the @inlinable bit in a follow-up
|
|
||
| @available(SwiftStdlib 6.2, *) | ||
| extension AsyncStream.Continuation: Hashable { | ||
| @available(SwiftStdlib 6.2, *) |
Member
There was a problem hiding this comment.
Should these all be @inlinable?
Contributor
Author
There was a problem hiding this comment.
| @available(SwiftStdlib 6.2, *) | ||
| extension AsyncThrowingStream.Continuation: Hashable { | ||
| @available(SwiftStdlib 6.2, *) | ||
| public func hash(into hasher: inout Hasher) { |
This was referenced Apr 28, 2025
ktoso
added a commit
that referenced
this pull request
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Adds hashable conformance and was approved in SE over here https://forums.swift.org/t/accepted-se-0468-hashable-conformance-for-async-throwing-stream-continuation/79116
Scope/Impact: Adds a Hashable conformance to AsyncStream.Continuation
Risk: Low, adding a conformance
Testing: CI testing
Reviewed by: @ktoso // PR on behalf of @nickolas-pohilets
Original PR: https://github.com/swiftlang/swift/pull/79457/files
Radar: rdar://149914179