🍒[cxx-interop] Workaround name lookup issues with namespace os
#78656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Apple platforms, a system module `os` declares a `namespace os` under `#if defined(__cplusplus)`. This causes ClangImporter to import it as `enum os` when C++ interop is enabled. This causes name lookup ambiguity (module os vs namespace os) which is resolved in namespace's favor, breaking existing usages. rdar://119044493 (cherry picked from commit 430809d)
|
@swift-ci please test |
Xazax-hun
approved these changes
Jan 15, 2025
The API that is being used is not available on all versions of all platforms. rdar://142973844
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: On Apple platforms, a system module
osdeclares anamespace osunder#if defined(__cplusplus). This causes ClangImporter to import it asenum oswhen C++ interop is enabled. This causes name lookup ambiguity (module os vs namespace os) which is resolved in namespace's favor, breaking existing usages.Scope: This changes ClangImporter to not import a particular C++ namespace into Swift.
Risk: Low, this only affects the import of C++ namespace named
osin a module namedos.Testing: Added a new compiler test.
Issue: rdar://119044493
Reviewer: @Xazax-hun
Original PR: #78634