Skip to content

LargeTypesReg2Mem: Map undef SIL values to an undefined address on the stack #76686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aschwaighofer merged 1 commit into from
Sep 25, 2024
Merged

LargeTypesReg2Mem: Map undef SIL values to an undefined address on the stack #76686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/IRGen/LoadableByAddress.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3510,7 +3510,7 @@ class AddressAssignment {
auto it = valueToAddressMap.find(v);

// This can happen if we deem a container type small but a contained type
// big.
// big or we have an undef operand.
if (it == valueToAddressMap.end()) {
if (auto *sv = dyn_cast<SingleValueInstruction>(v)) {
auto addr = createAllocStack(v->getType());
Expand All @@ -3520,6 +3520,12 @@ class AddressAssignment {
mapValueToAddress(v, addr);
return addr;
}
if (isa<SILUndef>(v)) {
auto undefAddr = createAllocStack(v->getType());
mapValueToAddress(v, undefAddr);
return undefAddr;
}

}
assert(it != valueToAddressMap.end());

Expand Down
33 changes: 33 additions & 0 deletions test/IRGen/loadable_by_address_reg2mem.sil
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,3 +364,36 @@ bb0(%0 : $*X):
dealloc_stack %1 : $*X
throw %3 : $X
}

// CHECK: sil @test15
// CHECK: cond_br %1, bb1, bb2

// CHECK: bb1:
// CHECK: copy_addr [take] {{.*}} to [init] [[PHI:%[0-9]+]] : $*X
// CHECK: br bb3

// CHECK: bb2:
// CHECK: [[UNDEF:%.*]] = alloc_stack $X
// CHECK: copy_addr [take] [[UNDEF]] to [init] [[PHI]] : $*X
// CHECK: dealloc_stack [[UNDEF]] : $*X
// CHECK: br bb3
// CHECK:} // end sil function 'test15'

sil @test15 : $@convention(thin) (X, Builtin.Int1) -> () {
bb0(%0: $X, %1: $Builtin.Int1):
%2 = alloc_stack $X
cond_br %1, bb1, bb2

bb1:
br bb3(%0 : $X)

bb2:
br bb3(undef : $X)

bb3(%4 : $X):
store %4 to %2: $*X

dealloc_stack %2 : $*X
%t = tuple ()
return %t : $()
}