- 
                Notifications
    
You must be signed in to change notification settings  - Fork 10.6k
 
          Typos (misc): cmake, tools, utils, unittests, validation-test + more
          #75034
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
a0687d5
              5ad9ee0
              4f7379c
              ade9a77
              f980976
              File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | 
|---|---|---|
| 
          
            
          
           | 
    @@ -64,6 +64,6 @@ TEST_F(ScanTest, TestDoesNotHaveArgumentQuery) { | |
| bool hasOption; | ||
| hasOption = optionSet.find("-clearly-not-a-compiler-flag") != optionSet.end(); | ||
| EXPECT_EQ(hasOption, false); | ||
| hasOption = optionSet.find("-emit-modul") != optionSet.end(); | ||
| hasOption = optionSet.find("-emit-module") != optionSet.end(); | ||
                
       | 
||
| EXPECT_EQ(hasOption, false); | ||
| } | ||
| Original file line number | Diff line number | Diff line change | 
|---|---|---|
| 
          
            
          
           | 
    @@ -340,7 +340,7 @@ def run(): | |
| ... // Licensed under Apache License v2.0 with Runtime Library Exception | ||
| ... // | ||
| ... // See https://swift.org/LICENSE.txt for license information | ||
| ... // See https://swift.org/CONTRIBUTORS.txt for the list of Swift projec | ||
| ... // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project | ||
| ... // | ||
| ... //===----------------------------------------------------------------- | ||
| ... | ||
| 
          
            
          
           | 
    @@ -408,7 +408,7 @@ def run(): | |
| ... return _base.underestimatedCount | ||
| ... } | ||
| ... | ||
| ... /// Creates an instance with elements `transform(x)` for each elemen | ||
| ... /// Creates an instance with elements `transform(x)` for each element | ||
| ... /// `x` of base. | ||
| ... @_inlineable | ||
| ... @_versioned | ||
| 
        
          
        
         | 
    @@ -433,7 +433,7 @@ def run(): | |
| ... // ###sourceLocation(file: "/public/core/Map.swift.gyb", line: 108) | ||
| ... | ||
| ... /// A `Collection` whose elements consist of those in a `Base` | ||
| ... /// `Collection` passed through a transform function returning `Elemen | ||
| ... /// `Collection` passed through a transform function returning `Element | ||
                
       | 
||
| ... /// These elements are computed lazily, each time they're read, by | ||
| ... /// calling the transform function on a base element. | ||
| ... @_fixed_layout | ||
| 
          
            
          
           | 
    @@ -471,7 +471,7 @@ def run(): | |
| ... // ###sourceLocation(file: "/public/core/Map.swift.gyb", line: 108) | ||
| ... | ||
| ... /// A `Collection` whose elements consist of those in a `Base` | ||
| ... /// `Collection` passed through a transform function returning `Elemen | ||
| ... /// `Collection` passed through a transform function returning `Element | ||
                
       | 
||
| ... /// These elements are computed lazily, each time they're read, by | ||
| ... /// calling the transform function on a base element. | ||
| ... @_fixed_layout | ||
| 
          
            
          
           | 
    @@ -509,7 +509,7 @@ def run(): | |
| ... // ###sourceLocation(file: "/public/core/Map.swift.gyb", line: 108) | ||
| ... | ||
| ... /// A `Collection` whose elements consist of those in a `Base` | ||
| ... /// `Collection` passed through a transform function returning `Elemen | ||
| ... /// `Collection` passed through a transform function returning `Element | ||
                
       | 
||
| ... /// These elements are computed lazily, each time they're read, by | ||
| ... /// calling the transform function on a base element. | ||
| ... @_fixed_layout | ||
| 
          
            
          
           | 
    ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While grammatically incorrect, I think that in general, this type of change is less desirable as it is changing terminology for variables rather than correcting an obvious typo. In this specific case, the rename is fine, but it is not always so obvious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. This array isn't an array of children. It's an array of "last child" flags.
lastChildrenis wrong. A better name might belastChildFlags.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!