[PackageCMO] Optimize witness thunks. #74468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci test |
- Keep witness thunk linkage private for a package protocol member in SILGen. - Optimize private/hidden functions during Package CMO; if they don't contain references that have private/hidden symbols, serialize them and set the linkage to shared. For unserialized witness thunks, set the linkage to package, so the witness table itself can be serialized. - Update witness table and vtable serialization. Resolves rdar://129976582
elsh
force-pushed
the
elsh/pcmo-conformance
branch
from
70a0526 to
534c35b
Compare
Contributor
Author
|
@swift-ci test |
elsh
added a commit
that referenced
this pull request
Jun 18, 2024
PR #74468 rolled back conformance serialized kind to IsNotSerialized for non-public decls. This caused static witness thunks to be removed while use site expects them, causing linker issues. This PR provides a workaround until a proper fix is made. rdar://130103572
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves rdar://129976582