Skip to content

Add a check for serialized_for_package in MandatoryInlining #73715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elsh wants to merge 1 commit into from
Closed

Add a check for serialized_for_package in MandatoryInlining #73715

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions lib/SILOptimizer/Mandatory/MandatoryInlining.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,6 +764,18 @@ getCalleeFunction(SILFunction *F, FullApplySite AI, bool &IsThick,
return nullptr;
}


// If the caller is [serialized] due to explicit `@inlinable` but
// the callee was [serialized_for_package] due to package-cmo, the
// callee is [serialized] and might contain loadable types, which
// is normally disallowed. This check prevents such loadable types
// from being inlined.
if (F->isSerialized() &&
!F->isSerializedForPackage() &&
CalleeFunction->isSerializedForPackage()) {
return nullptr;
}

return CalleeFunction;
}

Expand Down