Skip to content

IRGen: memcpy instead of the outlined copy with take #73461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aschwaighofer merged 1 commit into from
May 7, 2024
Merged

IRGen: memcpy instead of the outlined copy with take #73461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/IRGen/GenEnum.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3283,7 +3283,10 @@ namespace {
bool zeroizeIfSensitive) const override {
if (!ElementsAreABIAccessible) {
emitInitializeWithTakeCall(IGF, T, dest, src);
} else if (isOutlined || T.hasParameterizedExistential()) {
} else if (isOutlined || T.hasParameterizedExistential() ||
(getPayloadTypeInfo().isFixedSize() && // can use memcpy
getPayloadTypeInfo().
isBitwiseTakable(ResilienceExpansion::Maximal))) {
emitIndirectInitialize(IGF, dest, src, T, IsTake, isOutlined);
} else {
callOutlinedCopy(IGF, dest, src, T, IsInitialization, IsTake);
Expand Down
24 changes: 24 additions & 0 deletions test/IRGen/copy_addr_lowering.sil
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
// RUN: %target-swift-frontend -module-name A -Xllvm -sil-disable-pass=LowerAggregateInstr -emit-ir %s | %FileCheck %s
sil_stage lowered

import Builtin
import Swift
import SwiftShims

struct S {
var s: ArraySlice<UInt8>
var i: ArraySlice<UInt8>.Index
}


// CHECK: define{{.*}} swiftcc void @copy_test(
// CHECK-NOT: call ptr @"$s1A1SVSgWOb"(
// CHECK: memcpy
// CHECK: ret void

sil @copy_test : $@convention(thin) (@in Optional<S>) -> @out Optional<S> {
bb0(%0 : $*Optional<S>, %1 : $*Optional<S>):
copy_addr [take] %1 to [init] %0 : $*Optional<S>
%5 = tuple ()
return %5 : $()
}