[Runtime] Fix generation of .lnk files for static linking.#71843
Merged
al45tair merged 1 commit intoswiftlang:mainfrom May 7, 2024
Merged
[Runtime] Fix generation of .lnk files for static linking.#71843al45tair merged 1 commit intoswiftlang:mainfrom
al45tair merged 1 commit intoswiftlang:mainfrom
Conversation
Contributor
Author
|
This sits on top of #71839. |
Contributor
Author
|
@swift-ci Please smoke test |
al45tair
force-pushed
the
eng/PR-123504757
branch
from
0f0d8ad to
5f0ef4c
Compare
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
Author
|
It's just these changes that need reviewing. The others are in upstream PRs and are being reviewed by other people. |
MaxDesiatov
approved these changes
May 3, 2024
Use the new `SWIFT_SDK_<sdk>_STATIC_LINKING_SUPPORTED` and `_STATIC_ONLY` flags instead of hardcoding support for Linux and WASI. Also, use the `_LIB_SUBDIR` variable rather than lowercasing the SDK. rdar://123504757
Contributor
Author
|
@swift-ci Please smoke test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the new
SWIFT_SDK_<sdk>_STATIC_LINKING_SUPPORTEDand_STATIC_ONLYflags instead of hardcoding support for Linux and WASI.Also, use the
_LIB_SUBDIRvariable rather than lowercasing the SDK.rdar://123504757