[Runtime][ELF] Mark metadata sections as retained.#71841
Closed
al45tair wants to merge 1 commit intoswiftlang:mainfrom
Closed
[Runtime][ELF] Mark metadata sections as retained.#71841al45tair wants to merge 1 commit intoswiftlang:mainfrom
al45tair wants to merge 1 commit intoswiftlang:mainfrom
Conversation
If section garbage collection is turned on in the linker, the metadata sections may be dropped as there are no external references to them. To fix this, we need to mark them as retained (add an 'R' to the declaration). rdar://123504095
Contributor
Author
|
@swift-ci Please smoke test |
Member
|
This has been tried before, #67476, didn't work then either. @keith and @kateinoigakukun, any input? |
Member
|
this is my current impression of the issue #67476 (comment) |
Contributor
Author
|
See also #71373 |
kateinoigakukun
approved these changes
Feb 26, 2024
Contributor
Author
|
Closing this as I have a more complete PR coming. |
Contributor
Author
|
New PR is #72061. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If section garbage collection is turned on in the linker, the metadata sections may be dropped as there are no external references to them.
To fix this, we need to mark them as retained (add an 'R' to the declaration).
rdar://123504095