Skip to content

build: update for cmark build revamp and split the build #70791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2024
Merged

build: update for cmark build revamp and split the build #70791

merged 1 commit into from
Jan 24, 2024

Conversation

@compnerd
Copy link
Member

@compnerd compnerd commented Jan 9, 2024

Extricate cmark from the unified build system. This is preparatory work to support building CMark GFM with dynamic linkage for sharing it across swift-markdown and the compiler. It also simplifies the build logic for the unified build.

@compnerd
Copy link
Member Author

compnerd commented Jan 9, 2024

CC: @QuietMisdreavus @ahoppen

@compnerd
Copy link
Member Author

compnerd commented Jan 9, 2024

Please test with following PRs:
swiftlang/swift-cmark#69

@swift-ci please build toolchain Windows platform

@compnerd
Copy link
Member Author

compnerd commented Jan 9, 2024

CC: @etcwilde

@QuietMisdreavus
Copy link
Contributor

QuietMisdreavus commented Jan 9, 2024

Toolchain build timed out.

swiftlang/swift-cmark#69

@swift-ci please build toolchain Windows platform

@compnerd
Copy link
Member Author

compnerd commented Jan 10, 2024

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Jan 10, 2024

Please test with following PRs:
swiftlang/swift-cmark#69

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Jan 12, 2024

Please test with following PRs:
swiftlang/swift-cmark#69

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Jan 12, 2024

Please test with following PRs:
swiftlang/swift-cmark#69

@swift-ci please test

1 similar comment
@compnerd
Copy link
Member Author

compnerd commented Jan 16, 2024

Please test with following PRs:
swiftlang/swift-cmark#69

@swift-ci please test

@compnerd
build: update for cmark build revamp and split the build
49a5098 
Extricate cmark from the unified build system. This is preparatory work
to support building CMark GFM with dynamic linkage for sharing it across
swift-markdown and the compiler. It also simplifies the build logic for
the unified build.
@compnerd
Copy link
Member Author

compnerd commented Jan 17, 2024

Please test with following PRs:
swiftlang/swift-cmark#69

@swift-ci please test

@compnerd
Copy link
Member Author

compnerd commented Jan 18, 2024

Please test with following PRs:
swiftlang/swift-cmark#69

@swift-ci please test macOS platform

1 similar comment
@compnerd
Copy link
Member Author

compnerd commented Jan 18, 2024

Please test with following PRs:
swiftlang/swift-cmark#69

@swift-ci please test macOS platform

@compnerd
Copy link
Member Author

compnerd commented Jan 19, 2024

Please test with following PRs:
swiftlang/swift-cmark#69

@swift-ci please build toolchain

@bnbarham bnbarham mentioned this pull request Jan 23, 2024
Merged
rintaro
rintaro previously approved these changes Jan 23, 2024
View reviewed changes
@rintaro rintaro dismissed their stale review January 23, 2024 23:37

mis-approved

@bnbarham bnbarham mentioned this pull request Jan 23, 2024
Merged
rintaro
rintaro reviewed Jan 23, 2024
View reviewed changes
@compnerd compnerd merged commit 0d3f6a9 into swiftlang:main Jan 24, 2024
@compnerd compnerd deleted the cmark branch January 24, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rintaro rintaro rintaro left review comments

@bnbarham bnbarham bnbarham approved these changes

@etcwilde etcwilde Awaiting requested review from etcwilde

@QuietMisdreavus QuietMisdreavus Awaiting requested review from QuietMisdreavus

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@compnerd @QuietMisdreavus @rintaro @bnbarham