[swift-syntax] Reduce number of jobs that verify generated files #68763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were checking that the generated files matched the code in CodeGeneration in a number of jobs, which was still a relict from when `gyb_syntax_support` lived in the swift repo and was thus possible to break with a PR to the swift repo. Now, CodeGeneration lives exclusively in the swift-syntax repo and thus the checked in generated files can only be broken by a swift-syntax change. Reduce the number of jobs that verify the generated files to: - swift-syntax macOS PR testing (no need to run CodeGeneration on macOS and Linux) - `buildbot_all_platforms,tools=RA,stdlib=RA`, which is used fro the macOS Pull Request status bot so we get signal if two PRs in swift-syntax raced and broke the checked in generated files And while at it, also only verify the formatting of swift-syntax on macOS. There’s no need to verify it on all platforms.
|
@swift-ci Please smoke test |
This was referenced Sep 26, 2023
bnbarham
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were checking that the generated files matched the code in CodeGeneration in a number of jobs, which was still a relict from when
gyb_syntax_supportlived in the swift repo and was thus possible to break with a PR to the swift repo. Now, CodeGeneration lives exclusively in the swift-syntax repo and thus the checked in generated files can only be broken by a swift-syntax change.Reduce the number of jobs that verify the generated files to:
buildbot_all_platforms,tools=RA,stdlib=RA, which is used fro the macOS Pull Request status bot so we get signal if two PRs in swift-syntax raced and broke the checked in generated filesAnd while at it, also only verify the formatting of swift-syntax on macOS. There’s no need to verify it on all platforms.