Skip to content

StackPromotion: fix a crash due to a problem in liferange evaluation#67331

Merged
eeckstein merged 1 commit intoswiftlang:mainfrom
eeckstein:fix-stack-promotion
Jul 18, 2023
Merged

StackPromotion: fix a crash due to a problem in liferange evaluation#67331
eeckstein merged 1 commit intoswiftlang:mainfrom
eeckstein:fix-stack-promotion

Conversation

@eeckstein
Copy link
Contributor

The analysis to check if an alloc_ref outlives it's "inner" liferange had a bug which resulted in a crash in the StackPromotion pass

rdar://112275272

The analysis to check if an alloc_ref outlives it's "inner" liferange had a bug which resulted in a crash in the StackPromotion pass

rdar://112275272
@eeckstein
Copy link
Contributor Author

@swift-ci test

@eeckstein
Copy link
Contributor Author

@swift-ci benchmark

@eeckstein eeckstein requested a review from atrick July 17, 2023 17:59
@eeckstein eeckstein merged commit be7ffee into swiftlang:main Jul 18, 2023
@eeckstein eeckstein deleted the fix-stack-promotion branch July 18, 2023 10:18
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Reviewed for CCC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants