[AST] Convert ASTContext::getSwiftName to a free function #65082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This helps lldb avoid creating ASTContexts (which can be costly), before they're really needed. |
The only state `getSwiftName` uses is its argument, and can be made a free function. Of note the inverse operation, `getKnownFoundationEntity`, is also a free function. This removes the requirement that callers have an `ASTContext` instance.
kastiglione
force-pushed
the
dl/ast-convert-astcontext-getswiftname-to-static
branch
from
5df8173 to
fb524c0
Compare
kastiglione
changed the title
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
|
swiftlang/llvm-project#6634 |
1 similar comment
Contributor
Author
|
swiftlang/llvm-project#6634 |
adrian-prantl
approved these changes
Apr 13, 2023
fredriss
approved these changes
Apr 13, 2023
Contributor
Author
|
@swift-ci test macOS Platform |
Contributor
Author
|
@swift-ci test Linux Platform |
Contributor
Author
|
swiftlang/llvm-project#6634 |
Contributor
Author
|
swiftlang/llvm-project#6634 |
kastiglione
deleted the
dl/ast-convert-astcontext-getswiftname-to-static
branch
Member
|
Is this change on |
Contributor
Author
|
Here's the cherry pick for main #65194 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only state
getSwiftNameuses is its argument, and can be made a free function. Of note, the inverse operation,getKnownFoundationEntity, is also a free function. This removes the requirement that callers have anASTContextinstance.Cherry-pick of #65194.