[Mem2Reg] Omit lexical moves for lexical values. #65022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just directly invoke the member function instead.
When promoting an `alloc_stack [lexical]` that is "owned" (i.e. not a store_borrow location), omit lexical lifetimes (represented with `move_value [lexical]` instructions) if the value being stored is already lexical. Such moves are redundant. rdar://99160718
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please benchmark |
Contributor
Author
|
@swift-ci Please Test Source Compatibility Release |
Contributor
Author
|
@swift-ci please test macos platform |
1 similar comment
Contributor
Author
|
@swift-ci please test macos platform |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When promoting an
alloc_stack [lexical]that is "owned" (i.e. not a store_borrow location), omit lexical lifetimes (represented withmove_value [lexical]instructions) if the value being stored is already lexical. Such moves are redundant.rdar://99160718