[5.9] Don't insert a destroy on uninitialized move-only memory. #64848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able. This is used to teach the checker that the thing being checked is supposed to be uninitialized at the mark_must_check point so that we don't put a destroy_addr there. The way this is implemented is that we always initially add assignable_but_not_consumable but in DI once we discover that the assign we are guarding is an init, we convert the assignable to its initable variant. rdar://106525988
Contributor
Author
|
@swift-ci Please test |
tbkka
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teach the checker that the thing being checked is supposed to be uninitialized at the mark_must_check point so that we don't put a destroy_addr there.
The way this is implemented is that we always initially add assignable_but_not_consumable but in DI once we discover that the assign we are guarding is an init, we convert the assignable to its initable variant.
Main PR: #64690
rdar://106525988