Skip to content

[cmake] Modify libedit target name to match LLVM's FindLibEdit #64193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swift-ci merged 1 commit into from
Mar 8, 2023
Merged

[cmake] Modify libedit target name to match LLVM's FindLibEdit #64193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cmake/modules/FindLibEdit.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,9 @@ else()
LibEdit_VERSION_STRING)
endif()

if(LibEdit_FOUND AND NOT TARGET libedit)
add_library(libedit UNKNOWN IMPORTED)
set_target_properties(libedit PROPERTIES
if(LibEdit_FOUND AND NOT TARGET LibEdit::LibEdit)
add_library(LibEdit::LibEdit UNKNOWN IMPORTED)
set_target_properties(LibEdit::LibEdit PROPERTIES
IMPORTED_LOCATION ${LibEdit_LIBRARIES}
INTERFACE_INCLUDE_DIRECTORIES ${LibEdit_INCLUDE_DIRS})
endif()
Expand Down
2 changes: 1 addition & 1 deletion tools/SourceKit/tools/sourcekitd-repl/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ if(NOT CMAKE_SYSTEM_NAME STREQUAL Darwin)
BlocksRuntime)
endif()
target_link_libraries(sourcekitd-repl PRIVATE
libedit)
LibEdit::LibEdit)

if(CMAKE_SYSTEM_NAME STREQUAL Darwin)
set_target_properties(sourcekitd-repl PROPERTIES
Expand Down