Skip to content

fix bad expansion of SWIFT_ENUM#63902

Merged
swift-ci merged 1 commit intomainfrom
QuietMisdreavus/enum-macro
Feb 25, 2023
Merged

fix bad expansion of SWIFT_ENUM#63902
swift-ci merged 1 commit intomainfrom
QuietMisdreavus/enum-macro

Conversation

@QuietMisdreavus
Copy link
Contributor

Fixes #63837

When i introduced the data-driven creation of the Objective-C compatibility header, i accidentally introduced a difference in the macro expansion for SWIFT_ENUM. This PR fixes this.

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please smoke test

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please smoke test and merge

@swift-ci swift-ci merged commit d7c31aa into main Feb 25, 2023
@swift-ci swift-ci deleted the QuietMisdreavus/enum-macro branch February 25, 2023 18:16
@devioustree
Copy link

@QuietMisdreavus I don't know what the release process looks like, but will this change and #63338 be cherry-picked into the 5.8 release branch?

@QuietMisdreavus
Copy link
Contributor Author

@devioustree I'm not sure about the exact state of things, but my impression so far is that the release branch is pretty locked-down. Let me see what i can do.

@devioustree
Copy link

Let me know if you need any support to argue for their inclusion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ambiguous expansion of macro SWIFT_ENUM in generated headers

3 participants