Skip to content

Navigation Menu

Appearance settings

View all features
- BY COMPANY SIZE
  Enterprises
  Small and medium teams
  Startups
  Nonprofits
- BY USE CASE
  App Modernization
  DevSecOps
  DevOps
  CI/CD
  View all use cases
- BY INDUSTRY
  Healthcare
  Financial services
  Manufacturing
  Government
  View all industries
View all solutions
- EXPLORE BY TOPIC
  AI
  Software Development
  DevOps
  Security
  View all topics
- EXPLORE BY TYPE
  Customer stories
  Events & webinars
  Ebooks & reports
  Business insights
  GitHub Skills
- SUPPORT & SERVICES
  Documentation
  Customer support
  Community forum
  Trust center
  Partners
- COMMUNITY
  GitHub SponsorsFund open source developers
- PROGRAMS
  Security Lab
  Maintainer Community
  Accelerator
  Archive Program
- REPOSITORIES
  Topics
  Trending
  Collections
- ENTERPRISE SOLUTIONS
  Enterprise platformAI-powered developer platform
- AVAILABLE ADD-ONS
  GitHub Advanced SecurityEnterprise-grade security features
  Copilot for BusinessEnterprise-grade AI features
  Premium SupportEnterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

swiftlang / swift Public

Notifications You must be signed in to change notification settings
Fork 10.6k
Star 69.4k

Code
Issues 5k+
Pull requests 1.3k
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Security
Insights

[CSSolver] Implementation of disjunction choice favoring algorithm#63585

Merged

xedin merged 60 commits intoswiftlang:mainswiftlang/swift:mainfrom

xedin:solver-perfxedin/swift:solver-perfCopy head branch name to clipboard

Dec 18, 2024

Conversation Commits60 (60)Checks Files changed

Merged

[CSSolver] Implementation of disjunction choice favoring algorithm#63585
xedin merged 60 commits intoswiftlang:mainfrom
xedin:solver-perf

Commits

Commits on Dec 17, 2024

[ConstraintSystem] Remove `shrink`
xedin
committed
[CSGen] Remove ConstraintOptimizer and all favoring logic
xedin
committed
[ConstraintSystem] Add skeleton of constraint optimizer
xedin
committed
[CSOptimizer] Initial implementation of disjunction choice favoring algorithm
xedin
committed
[CSOptimizer] Favor SIMD related arithmetic operator choices if argument is SIMD<N> type
xedin
committed
[CSOptimizer] Keep track of mismatches while evaluating candidates
xedin
committed
[CSStep] Don't favor choices until the disjunction is picked
xedin
committed
[CSOptimizer] Make sure that all parameters without arguments are defaulted
xedin
committed
[CSOptimizer] Allow generic operator overloads without associated type parameters
xedin
committed
[CSOptimizer] Don't attempt to optimize calls with code completion token(s) in argument position
xedin
committed
[CSOptimizer] Use `matchCallArguments` to establish argument-to-parameter relationships
xedin
committed
[CSOptimizer] Relax candidate type requirements from equality to set of no-impact conversions
xedin
committed
[CSStep] Remove disjunction pruning logic from DisjunctionStep
xedin
committed
[CSOptimizer] Treat all type parameters equally
xedin
committed
[CSOptimizer] NFC: Adjust conformance check to use `ConstraintSystem::lookupConformance`
xedin
committed
[CSOptimizer] NFC: Switch to llvm::Optional
xedin
committed
[CSOptimizer] Increase score when type matches opaque type
xedin
committed
[CSOptimizer] NFC: Switch from llvm::Optional to std::optional post-rebase
xedin
committed
[CSOptimizer] Remove an outdated optimization to compare resolved argument types with all else equal
xedin
committed
[CSOptimizer] Prefer homogeneous arithmetic operator overloads when argument(s) or result match
xedin
committed
[Tests] NFC: Add a test-case for rdar://133340307 which is now fast
xedin
committed
[CSOptimizer] Emulate old behavior related to favoring of unary calls to members
xedin
committed
[CSOptimizer] Let `determineBestChoicesInContext` return the best disjunction if one is available
xedin
committed
[CSOptimizer] Record best scores for each disjunction and use them in `selectDisjunction`
xedin
committed
[CSOptimizer] attempt to rank only standard/simd operators and fully concrete overload sets
xedin
committed
[CSOptimizer] Don't optimize (implicit) calls with code completion arguments
xedin
committed
[Tests] NFC: Adjust a couple of improved tests
xedin
committed
[CSOptimizer] Average score should reflect number of defaulted parameters
xedin
committed
[Tests] NFC: Add more test-cases that were previously solved due to old hacks behavior
xedin
committed
[CSOptimizer] Rank results of operators regardless of whether anything is known about parameters
xedin
committed
[CSOptimizer] Rank disjunctions based on score only if both sides are supported
xedin
committed
[CSOptimizer] Enable ranking of `Int*`, `Float{80}` and `Double` initializers
xedin
committed
[CSOptimizer] Score all of the overload choices matching on literals uniformly
xedin
committed
[CSOptimizer] Infer argument candidates from calls to `Double` and CGFloat constructors
xedin
committed
[ConstraintSystem] Narrowly disable `tryOptimizeGenericDisjunction` when some of the arguments are number literals
xedin
committed
[CSOptimizer] Desugar types before checking for equality
xedin
committed
[CSOptimizer] Restore old hack behavior which used to favor overloads based on arity matches
xedin
committed
[CSOptimizer] A more comprehensive generic overload checking when candidates are fully resolved
xedin
committed
[CSOptimizer] Fix Double<->CGFloat implicit conversion support when arguments are literals
xedin
committed
[CSOptimizer] Adjust `scoreCandidateMatch` to indicate when match cannot be decided
xedin
committed
[CSOptimizer] Allow literal arguments to match parameters that conform to `ExpressibleBy{Integer, Float}Literal`
xedin
committed
[CSGen] NFC: Remove obsolete `ConstraintSystem::{get, set}FavoredType`
xedin
committed
[Tests] NFC: Move simd related test-case from `slow` to `fast`
xedin
committed
[Tests] NFC: Update a couple of type-checker tests
xedin
committed
[CSOptimizer] Limit "old" behavior compatibility to unlabeled unary arguments
xedin
committed
[CSOptimizer] Fix `selectDisjunction` to use favored choices even if disjunction was not optimized
xedin
committed
[CSOptimizer] Make a light-weight generic overload check if some requirements are unsatisfiable
xedin
committed
[CSOptimizer] Mark compiler synthesized disjunctions as optimized
xedin
committed
[CSOptimizer] Add support for chained members without arguments
xedin
committed
[CSBindings] Prevent `BindingSet::isViable` from dropping viable bindings (v2)
xedin
committed
[CSSimplify] CGFloat-Double: Rank narrowing correctly when result is injected into an optional
xedin
committed
[CSOptimizer] Allow only widening CGFloat->Double conversions while matching candidate arguments
xedin
committed
[CSOptimizer] Implement special prioritization rules for result builder contexts
xedin
committed
[CSBindings] Don't attempt to strip optional for closure result types
xedin
committed
[CSOptimizer] Reduce overload types before ranking
xedin
committed
[ConstraintSystem] Fix `getEffectiveOverloadType` handling of `mutating` methods
xedin
committed
[TypeCheckEffects] Downgrade missing `await` to a warning for initializer calls with a single unlabeled parameter
xedin
committed

Commits on Dec 18, 2024

[CSOptimizer] Simplify handling of non-applied disjunctions
xedin
committed
[CSOptimizer] Mark bitwise operators as supported
xedin
committed
[CSOptimizer] Disable CGFloat -> Double conversion for unary operators
xedin
committed

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.