Skip to content

Conversation

@compnerd
Copy link
Member

@compnerd compnerd commented Feb 3, 2023

We should be able to use static linking here without negatively impacting code size.


Cherry pick of #63393.

We should be able to use static linking here without negatively impacting code size.
@compnerd
Copy link
Member Author

compnerd commented Feb 3, 2023

Please test with following PRs:
swiftlang/swift-installer-scripts#173

@swift-ci please build toolchain windows platform

@compnerd
Copy link
Member Author

compnerd commented Feb 6, 2023

@swift-ci please smoke test

@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd
Copy link
Member Author

CC: @airspeedswift @DougGregor @shahmishal - this has been here for a while, it is a pretty straightforward change and only impacts windows.

@compnerd
Copy link
Member Author

@swift-ci please test macOS platform

@compnerd
Copy link
Member Author

CC: @tkremenek

@tkremenek
Copy link
Member

@compnerd, thanks for CC'ing me. I'm missing some context behind the change. What does it do?

@compnerd
Copy link
Member Author

@tkremenek it just changes the Windows build to use static linking for the SwiftCrypto library for use in Swift PM. It's a small size and distribution win. This is a build only change that is limited to windows. There is the associated change for swift-installer-scripts but is quite self contained.

@tkremenek tkremenek merged commit 9206c5d into swiftlang:release/5.8 Feb 22, 2023
@compnerd compnerd deleted the 5.8-static-crypto branch February 24, 2023 05:45
@AnthonyLatsis AnthonyLatsis added the 🍒 release cherry pick Flag: Release branch cherry picks label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍒 release cherry pick Flag: Release branch cherry picks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants