Skip to content

Conversation

@modocache
Copy link
Contributor

Addresses a FIXME to specify ABI type in the driver invocation.


See #439 for additional context.

Addresses a FIXME to specify ABI type in the driver invocation.
@gribozavr
Copy link
Contributor

@modocache As discussed in another PR, we'd need to change the CMake logic to put the library in a different directory. Do you have access to a Linux machine so that you can test?

@hpux735
Copy link
Contributor

hpux735 commented Dec 14, 2015

There are a few places to look for changes. One is cmake/modules/AddSwift:44

# Compute the library subdirectory to use for the given sdk and
# architecture, placing the result in 'result_var_name'.
function(compute_library_subdir result_var_name sdk arch)
  set("${result_var_name}" "${SWIFT_SDK_${sdk}_LIB_SUBDIR}/${arch}" PARENT_SCOPE)
endfunction()

There are quite a few places with similar references.

@hpux735
Copy link
Contributor

hpux735 commented Dec 20, 2015

There's another issue with ABIs that would be nice to have fixed. In the Foundation build scripts, I have to assume gnueabihf if it's an ARM, otherwise it won't build.

@gottesmm
Copy link
Contributor

gottesmm commented Mar 1, 2016

This sounds like something for @jrose-apple.

@gottesmm gottesmm assigned gottesmm and jrose-apple and unassigned gottesmm Mar 1, 2016
@modocache
Copy link
Contributor Author

Sorry to keep this open so long. It's outdated to the point that the FIXME being addressed doesn't even exist anymore!

@modocache modocache closed this Mar 14, 2016
freak4pc pushed a commit to freak4pc/swift that referenced this pull request Sep 28, 2022
[SourceKit XFails] Update XFails
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants