GSB: Remove a couple of well-formedness assertions [5.4] #38013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
approved these changes
Jun 21, 2021
Contributor
|
@shahmishal we should pull this into the next 5.4 linux/windows dot release |
Member
|
@swift-ci please test |
Contributor
|
Build failed |
Contributor
|
Build failed |
The underlying issue here won't be fixed in 5.4 and 5.5, so remove the asserts to avoid allowing code in no-asserts builds that is rejected in asserts builds. Any code that builds with this assert commented out might fall victim to an ABI break once the bug with same-type requirement minimization is actually fixed. "Fixes" https://bugs.swift.org/browse/SR-14776.
slavapestov
force-pushed
the
allow-bogus-same-type-in-signature-5.4
branch
from
2bc2e16 to
cec3b11
Compare
Contributor
Author
|
@swift-ci please test |
airspeedswift
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying issue here won't be fixed in 5.4 and 5.5, so remove the
asserts to avoid allowing code in no-asserts builds that is rejected in
asserts builds.
Any code that builds with this assert commented out might fall victim
to an ABI break once the bug with same-type requirement minimization
is actually fixed.
"Fixes" https://bugs.swift.org/browse/SR-14776.