Skip to content

[NFC] Introduce isDecl and getDeclType#36953

Merged
Azoy merged 1 commit intoswiftlang:mainfrom
Azoy:isType-isDeclType
Apr 20, 2021
Merged

[NFC] Introduce isDecl and getDeclType#36953
Azoy merged 1 commit intoswiftlang:mainfrom
Azoy:isType-isDeclType

Conversation

@Azoy
Copy link
Contributor

@Azoy Azoy commented Apr 18, 2021

Alright, let's give this another go! This is resurrecting an older PR I made here: #27195 .

@Azoy Azoy requested a review from CodaFi April 18, 2021 05:36
@Azoy
Copy link
Contributor Author

Azoy commented Apr 19, 2021

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - ddad32354ae48b6ff40fd17b3838e34d2e664da9

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - ddad32354ae48b6ff40fd17b3838e34d2e664da9

@Azoy Azoy force-pushed the isType-isDeclType branch 2 times, most recently from 8ee9eb5 to 102e3e3 Compare April 19, 2021 20:46
@Azoy
Copy link
Contributor Author

Azoy commented Apr 19, 2021

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 102e3e30d26d65ee591a041e5bb2c2048603ca22

fix enum logic issue

fix tests

guard against null types
@Azoy Azoy force-pushed the isType-isDeclType branch from 102e3e3 to 9ed732f Compare April 20, 2021 06:23
@Azoy
Copy link
Contributor Author

Azoy commented Apr 20, 2021

@swift-ci please test

@Azoy Azoy merged commit 444c35c into swiftlang:main Apr 20, 2021
@Azoy Azoy deleted the isType-isDeclType branch April 20, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants