Closed
Conversation
Member
Author
Member
Author
|
@swift-ci please smoke test |
artemcm
reviewed
Jul 23, 2020
Contributor
There was a problem hiding this comment.
This fix is missing the removal of the comma after the last object element that I had in the other PR.
Member
Author
There was a problem hiding this comment.
Ah, good point. That is optional - I can add it or it can be a follow up. The reason that it is not needed is because the list itself contains objects. Objects can have trailing commas.
Contributor
|
lit.cfg:1444 needs to be: |
Repair the Windows build after swiftlang#32903
Member
Author
|
Bleh, adjusted. Thanks @artemcm |
Member
Author
|
@swift-ci please smoke test |
Member
Author
|
@swift-ci please test windows platform |
Contributor
Member
Author
|
Oh,nice, let's go with that since it's ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repair the Windows build after #32903
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.