Skip to content

[test] Enable standalone_build feature properly and fix three tests #32954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davezarzycki merged 1 commit into from
Jul 20, 2020
Merged

[test] Enable standalone_build feature properly and fix three tests #32954

davezarzycki merged 1 commit into from
Jul 20, 2020

Conversation

@finagolfin
Copy link
Member

@finagolfin finagolfin commented Jul 17, 2020

@davezarzycki, if you can kick off the CI, I believe this will enable all those tests.

@theblixguy
Copy link
Collaborator

theblixguy commented Jul 17, 2020

@swift-ci please test

@theblixguy theblixguy requested a review from davezarzycki July 17, 2020 18:23
davezarzycki
davezarzycki approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@davezarzycki davezarzycki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing this!

@swift-ci
Copy link
Contributor

swift-ci commented Jul 17, 2020

Build failed
Swift Test OS X Platform
Git Sha - 076761415a6b6bf0e5514859f66ff74211f9e3f9

@finagolfin
Copy link
Member Author

finagolfin commented Jul 17, 2020

Well, the fact that one standalone_build test now fails on macOS shows that they're running now, I'll look into why it fails.

@swift-ci
Copy link
Contributor

swift-ci commented Jul 17, 2020

Build failed
Swift Test Linux Platform
Git Sha - 076761415a6b6bf0e5514859f66ff74211f9e3f9

@finagolfin
[test] Enable standalone_build feature properly and fix three tests
09e30ef 
Two tests were mislabeled and a third needed its output reordered.
@finagolfin finagolfin changed the title [test] Enable standalone_build feature properly and fix two mislabeled tests [test] Enable standalone_build feature properly and fix three tests Jul 17, 2020
@finagolfin
Copy link
Member Author

finagolfin commented Jul 17, 2020

Good to test.

@finagolfin finagolfin mentioned this pull request Jul 17, 2020
Merged
@finagolfin
Copy link
Member Author

finagolfin commented Jul 18, 2020

Ready for another CI run, should pass now.

@davezarzycki
Copy link
Contributor

davezarzycki commented Jul 18, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Jul 18, 2020

Build failed
Swift Test OS X Platform
Git Sha - 076761415a6b6bf0e5514859f66ff74211f9e3f9

@swift-ci
Copy link
Contributor

swift-ci commented Jul 18, 2020

Build failed
Swift Test Linux Platform
Git Sha - 076761415a6b6bf0e5514859f66ff74211f9e3f9

@finagolfin
Copy link
Member Author

finagolfin commented Jul 18, 2020

Single linux failure is unrelated, all pulls on CI are failing because of that same test.

@davezarzycki
Copy link
Contributor

davezarzycki commented Jul 19, 2020

@swift-ci please smoke test linux

@finagolfin
Copy link
Member Author

finagolfin commented Jul 20, 2020

Passes CI, ready to merge.

@davezarzycki davezarzycki merged commit 35255ad into swiftlang:master Jul 20, 2020
@davezarzycki
Copy link
Contributor

davezarzycki commented Jul 20, 2020

Thanks for fixing this :-)

@finagolfin
Copy link
Member Author

finagolfin commented Jul 20, 2020

Thanks for answering my questions and the quick turnaround, now to get my other pull that depends on this in.

@finagolfin finagolfin deleted the standalone branch July 20, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davezarzycki davezarzycki davezarzycki approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@finagolfin @theblixguy @swift-ci @davezarzycki