Skip to content

Conversation

@shahmishal
Copy link
Member

No description provided.

shahmishal added 30 commits July 3, 2020 01:06
Most of the changes fall into a few categories:
* Replace explicit "x86_64" with %target-cpu in lit tests
* Cope with architecture differences in IR/asm/etc. macOS-specific tests
…n macOS.

Most of this is enabled by an upstream change to generalize the tests
for the api-digester to properly handle all targets. The primary change
here is to account for the Swift-level ABI differences for the standard
library between Apple Silicon macOS and Intel macOS. Specifically, anything
related to Float80 will be removed from the standard library on Apple Silicon
macOS, so account for the differences.
…iling

clang and compiler-rt are rev-locked and should match.  Currently, we build clang (and use it to bootstrap the rest) but don't build compiler-rt.  We should.

This doesn't completely achieve that: this only makes us build compiler-rt for the local host.

This used to be pretty much impossible, but, since then, compiler-rt cmake support was rewritten.

We should build it for the other hosts as well, but that's trickier, because we'd need to make the cross-compiled compiler-rt build use a separate just-built clang (from the local host). We do that for the other projects, but compiler-rt is special (because it's cmake'd as a runtime part of clang/llvm).
…acy-impl.

LIPO_SRC_DIRS wasn't set for '--only-execute merged-hosts-lipo',
because the logic was skipped for actions other than install.
@shahmishal shahmishal requested a review from a team as a code owner July 3, 2020 23:53
@shahmishal
Copy link
Member Author

@swift-ci test

@shahmishal shahmishal requested a review from DougGregor July 3, 2020 23:55
@theblixguy theblixguy added the r5.3 label Jul 4, 2020
@shahmishal shahmishal merged commit 3b9218a into release/5.3 Jul 5, 2020
@shahmishal shahmishal deleted the apple-silicon-5.3 branch July 5, 2020 02:08
@varungandhi-apple
Copy link
Contributor

I don't see these changes on master yet, is that intentional?

@shahmishal
Copy link
Member Author

I will merge it soon #32705

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍒 release cherry pick Flag: Release branch cherry picks swift 5.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants