[AutoDiff] Fix unexpected non-differentiable property access error.#32670
Merged
dan-zheng merged 1 commit intoswiftlang:masterfrom Jul 5, 2020
Merged
Conversation
dan-zheng
commented
Jul 1, 2020
Contributor
Author
There was a problem hiding this comment.
Note: adding a base type parameter to TangentStoredPropertyRequest results in fewer cache hits.
It may be possible to fix SR-13134 without adding a base type parameter, I may take a look later.
Contributor
Author
|
@swift-ci Please smoke test |
rxwei
approved these changes
Jul 2, 2020
Add base type parameter to `TangentStoredPropertyRequest`. Use `TypeBase::getTypeOfMember` instead of `VarDecl::getType` to correctly compute the member type of original stored properties, using the base type. Resolves SR-13134.
dad21de to
007b216
Compare
Contributor
Author
|
@swift-ci Please smoke test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add base type parameter to
TangentStoredPropertyRequest.Use
TypeBase::getTypeOfMemberinstead ofVarDecl::getTypeto correctlycompute the member type of original stored properties, using the base type.
Resolves SR-13134.
Example:
Before:
After: no error, as expected.