ExplictModuleLoader: update acceptable JSON format to be more Codable friendly#32450
Merged
nkcsgexi merged 1 commit intoswiftlang:masterfrom Jun 18, 2020
Merged
Conversation
… friendly Explicit Swift module map will be constructed from the swift-driver side using the Codable protocol. We should change the format to facilitate that.
Contributor
Author
|
@swift-ci please smoke test |
1 similar comment
Contributor
Author
|
@swift-ci please smoke test |
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Jun 19, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file`
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Jun 19, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file` Resolves rdar://problem/64533451
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Jun 19, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file` Resolves rdar://problem/64533451
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Jun 19, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file` Resolves rdar://problem/64533451
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Jun 19, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file` Resolves rdar://problem/64533451
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Jun 19, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file` Resolves rdar://problem/64533451
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Jun 22, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file` Resolves rdar://problem/64533451
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Jun 22, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file` Resolves rdar://problem/64533451
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Jun 22, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file` Resolves rdar://problem/64533451
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Jun 23, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file` Resolves rdar://problem/64533451
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Jun 23, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file` Resolves rdar://problem/64533451
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Jun 23, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file` Resolves rdar://problem/64533451
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Jun 24, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file` Resolves rdar://problem/64533451
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Jun 29, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file` Resolves rdar://problem/64533451
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Jul 1, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file` Resolves rdar://problem/64533451
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Jul 1, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file` Resolves rdar://problem/64533451
xymus
pushed a commit
to xymus/swift-driver
that referenced
this pull request
Nov 6, 2020
…xplicit Swift module dependencies This PR implements the interface expected by the frontend, as built in: swiftlang/swift#32355 swiftlang/swift#32450 Swift module's explicit Swift module dependencies are now encoded in a JSON file, passed with `-explicit-swift-module-map-file` Resolves rdar://problem/64533451
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicit Swift module map will be constructed from the swift-driver side using
the Codable protocol. We should change the format to facilitate that.