[Typechecker] Diagnose use of magic literals as raw value for enum case#32364
Merged
theblixguy merged 1 commit intoswiftlang:masterfrom Jun 15, 2020
theblixguy:fix/SR-12998
Merged
[Typechecker] Diagnose use of magic literals as raw value for enum case#32364theblixguy merged 1 commit intoswiftlang:masterfrom theblixguy:fix/SR-12998
theblixguy merged 1 commit intoswiftlang:masterfrom
theblixguy:fix/SR-12998
Conversation
Collaborator
Author
|
@swift-ci please smoke test |
CodaFi
approved these changes
Jun 15, 2020
Contributor
CodaFi
left a comment
CodaFi
left a comment
There was a problem hiding this comment.
I'll take this over a crash, but could you test more kinds of literals?
Collaborator
Author
|
I have added a few more test cases (including a test for object literals). Should I cherry-pick this to 5.3 too? @swift-ci please test |
CodaFi
approved these changes
Jun 15, 2020
Contributor
|
Thanks for the tests. I don't think this needs to go into 5.3. @swift-ci please smoke test |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't support use of magic literals like
#fileor#lineas raw values for an enum case. At the moment, the compiler simply crashes when it comes across such literals. I think we can support them but that involves a bit more work so for now let's just diagnose them as unsupported instead of crashing the compiler.Resolves SR-12998